Nir Soffer has posted comments on this change. Change subject: yml: parameter type fixes for StoragePool.connectStorageServer ......................................................................
Patch Set 1: Code-Review-1 (3 comments) https://gerrit.ovirt.org/#/c/59701/1/lib/api/vdsm-api.yml File lib/api/vdsm-api.yml: Line 341 Line 342 Line 343 Line 344 Line 345 Why did you removed these? How is this related to bad parameters or return value? Line 5593 Line 5594 Line 5595 Line 5596 Line 5597 Do not remove these - these are the correct values that should be used in new code. Please add new type - StorageDomainTypeId for the numbers. We will use StorageDomainTypeId in the verbs that accept or retrun numbers instead of strings. Line 5543: 1: The Storage Domain uses Network File System based storage Line 5544: 0: The type is not known Line 5545: 6: The Storage Domain uses posix file system Line 5546: 7: The Storage Domain uses glusterfs Line 5547: 8: The Storage Domain uses cinder We don't have this type and we will never have this. Cinder is not a storage domain type. On vdsm side, we work only with storage backends such as ceph. Cinder exists only on the engine side. Line 5548: Line 5549: StorageDomainInfo: &StorageDomainInfo Line 5550: added: '3.1' Line 5551: description: Information about a Storage Domain. -- To view, visit https://gerrit.ovirt.org/59701 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9fe2ffc3bc2327eefaae794b7b366e8202d2f2a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
