Edward Haas has posted comments on this change.

Change subject: ovs: flush IP config from attached nics
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/59958/5/lib/vdsm/network/netswitch.py
File lib/vdsm/network/netswitch.py:

Line 226:             flush_nic_ip(nic)
Line 227: 
Line 228: 
Line 229: def _flush_ip_config(iface, family):
Line 230:     dhclient.kill(iface, family)  # kills dhclient and flushes IP
What about static IP/s?
Line 231: 
Line 232: 
Line 233: def _set_dhcp_config(iface, attrs):
Line 234:     # TODO: DHCPv6


-- 
To view, visit https://gerrit.ovirt.org/59958
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I66e0be6ea8583fae1814bb8fc776dd243932b192
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phora...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phora...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Reply via email to