Edward Haas has posted comments on this change. Change subject: virt net: Support VM migration on OVS based networks ......................................................................
Patch Set 10: (2 comments) https://gerrit.ovirt.org/#/c/59645/10/vdsm/virt/libvirt-hook.sh File vdsm/virt/libvirt-hook.sh: Line 18: # Fix VMs migrating to host with libvirt >= 1.2.8 Line 19: # See https://bugzilla.redhat.com/show_bug.cgi?id=1138340 Line 20: if [ -x /usr/libexec/vdsm/vm_migrate_hook.py ]; then Line 21: sed -e 's|<min_guarantee[^>]*>[0-9 ]*</min_guarantee>||g' | /usr/libexec/vdsm/vm_migrate_hook.py $DOMAIN $EVENT $PHASE Line 22: elif [ -x /usr/libexec/vdsm/ovs_migrate.py ]; then > so we could not have both installed? Yes, we have not yet removed the ovs hook. But even if it is installed, we will not use the ovs hook. There should be a separated patch that takes the ovs hook out. Line 23: sed -e 's|<min_guarantee[^>]*>[0-9 ]*</min_guarantee>||g' | /usr/libexec/vdsm/ovs_migrate.py $DOMAIN $EVENT $PHASE Line 24: else Line 25: sed -e 's|<min_guarantee[^>]*>[0-9 ]*</min_guarantee>||g' Line 26: fi https://gerrit.ovirt.org/#/c/59645/10/vdsm/virt/vm_migrate_hook.py File vdsm/virt/vm_migrate_hook.py: Line 28: from vdsm.network import api as net_api Line 29: Line 30: Line 31: _DEBUG_MODE = False Line 32: LOG_FILE = '/tmp/libvirthook_ovs_migrate.log' > why not log in /var/log/vdsm ? Because this is running in the context of libvirt. Line 33: Line 34: Line 35: class VmMigrationHookError(Exception): Line 36: pass -- To view, visit https://gerrit.ovirt.org/59645 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7d32f9605f9ca99d1e07062108f2567806ac59c Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
