Nir Soffer has posted comments on this change. Change subject: yml: return type fixes for Host.hostdevListByCaps ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/59703/1/tests/vdsmapi_test.py File tests/vdsmapi_test.py: Line 495: Line 496: _schema.schema().verify_args( Line 497: vdsmapi.MethodRep('StoragePool', 'connect'), params) Line 498: Line 499: def test_host_list_caps(self): > Once we know that schema is aligned with runtime we will remove these tests We will never remove these tests, and in the meantime we will waste time on reviewing this. The tests should test the verification code, not the schema. The will be good if they do not use the schema, but a special test schema. Line 500: ret = {'net_eth0_52_54_00_56_00_39': Line 501: {'params': {'capability': 'net', Line 502: 'interface': 'eth0', Line 503: 'parent': 'pci_0000_00_03_0', -- To view, visit https://gerrit.ovirt.org/59703 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ad09c310a76dde9267824a337fadf3b1c02bd45 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
