Francesco Romani has submitted this change and it was merged. Change subject: rpc: Use Suppressed class instead of logging workarounds ......................................................................
rpc: Use Suppressed class instead of logging workarounds We have got logging workarounds for getAllVmStats RPC calls. The workarounds are there to suppress logging large data regularly. We'd like to get rid of the workarounds, it's better to handle the large data in the API functions, where we can use specific handling of each kind of large data. This patch introduces a wrapper for large values, with the purpose of suppressing writing them to the log. The wrapper is used for getAllVmStats so that we get rid of the logging workarounds. There are other API calls that may produce large outputs, we will handle them in followup patches. Change-Id: Idaf00e557fccb8f08fa3aeb38d51cb4bbe0ffe53 Signed-off-by: Milan Zamazal <[email protected]> Bug-Url: https://bugzilla.redhat.com/1351247 Backport-To: 4.0 Backport-To: 3.6 Reviewed-on: https://gerrit.ovirt.org/59078 Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer <[email protected]> Reviewed-on: https://gerrit.ovirt.org/59994 Reviewed-by: Francesco Romani <[email protected]> --- M lib/api/vdsmapi.py M lib/vdsm/logUtils.py M lib/vdsm/rpc/bindingxmlrpc.py M lib/yajsonrpc/__init__.py M vdsm/API.py 5 files changed, 30 insertions(+), 9 deletions(-) Approvals: Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved Milan Zamazal: Verified -- To view, visit https://gerrit.ovirt.org/59994 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idaf00e557fccb8f08fa3aeb38d51cb4bbe0ffe53 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Milan Zamazal <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
