Tomas Jelinek has posted comments on this change.

Change subject: migration: wait properly for migration to begin
......................................................................


Patch Set 3:

(4 comments)

https://gerrit.ovirt.org/#/c/60073/2//COMMIT_MSG
Commit Message:

PS2, Line 13: even tho
> ... even though the ... ?
Done


PS2, Line 17: ure the
> ... present
Done


PS2, Line 18: 
> ... its
Done


https://gerrit.ovirt.org/#/c/60073/2/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 705: 
Line 706:             if self._stop.isSet():
Line 707:                 break
Line 708: 
Line 709:             self.progress = progress
> Is this condition still necessary?
right, not needed.
Line 710:             self._vm.log.info('%s', progress)
Line 711: 
Line 712:     def stop(self):
Line 713:         self._vm.log.debug('stopping migration monitor thread')


-- 
To view, visit https://gerrit.ovirt.org/60073
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If1ba369a0992c2473acf1395fad0b0c260c250ba
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/admin/lists/[email protected]

Reply via email to