Vinzenz Feenstra has posted comments on this change. Change subject: tests: add a rollback manager for easy undoing ......................................................................
Patch Set 3: I would prefer that you didn't submit this (1 inline comment) The only thing I would like to see is the tests list in Makefile.am to be sorted, other than that it looks good to me. So basically a minority for the change, however it'd be useful Thank you. .................................................... File tests/Makefile.am Line 43: permutationTests.py \ Line 44: persistentDictTests.py \ Line 45: restTests.py \ Line 46: restData.py \ Line 47: rollbackManagerTests.py \ Can we please sort this list by name? Thank you Line 48: tcTests.py \ Line 49: vdsClientTests.py \ Line 50: remoteFileHandlerTests.py \ Line 51: resourceManagerTests.py -- To view, visit http://gerrit.ovirt.org/8671 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc932637dd81c3becf92de34ea647c1cea136111 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
