Petr Horáček has posted comments on this change. Change subject: test: Introduce mock module for testing ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/59797/2/vdsm.spec.in File vdsm.spec.in: Line 58: Line 59: BuildRequires: cyrus-sasl-lib Line 60: BuildRequires: python Line 61: BuildRequires: python-devel Line 62: BuildRequires: python-mock BTW why don't we require such modules only when python2 is used? Build requires packages for both just to enable tests to run with Python 2 and 3 as well? Line 63: BuildRequires: python-netaddr Line 64: BuildRequires: python-nose Line 65: BuildRequires: python-six >= 1.9.0 Line 66: BuildRequires: rpm-build -- To view, visit https://gerrit.ovirt.org/59797 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72edd0a9388f11d905cfbd7d2fac5a95e1212cea Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
