Piotr Kliczewski has posted comments on this change. Change subject: schema: use datatype to silence inconsistencies ......................................................................
Patch Set 3: (4 comments) https://gerrit.ovirt.org/#/c/59258/3/contrib/refmt File contrib/refmt: Line 1: #!/usr/bin/python separate patch? Line 2: Line 3: # helper script to prettify Vdsm parameter dumps from the logs. Line 4: # useful to extract test data. Line 5: # This tool is intended to make it easier for humans to read https://gerrit.ovirt.org/#/c/59258/3/lib/api/vdsm-api.yml File lib/api/vdsm-api.yml: PS3, Line 4039: needs updating Do we want to update here? https://gerrit.ovirt.org/#/c/59258/3/tests/testlib.py File tests/testlib.py: Line 566: raise exception Line 567: return wrapper Line 568: Line 569: Line 570: def read_data(filename): separate patch? Line 571: test_path = os.path.realpath(__file__) Line 572: dir_name = os.path.dirname(test_path) Line 573: path = os.path.join(dir_name, filename) Line 574: with open(path) as src: https://gerrit.ovirt.org/#/c/59258/3/tests/vdsmapi_test.py File tests/vdsmapi_test.py: PS3, Line 450: eval(read_data('vmcreate_args.out')) I like it -- To view, visit https://gerrit.ovirt.org/59258 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2650f221ae1e06fa11ee127d5c8fb94e7be0d900 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
