Nir Soffer has posted comments on this change. Change subject: Using startCmd func for running async execution ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/60237/1/lib/vdsm/commands.py File lib/vdsm/commands.py: Line 46: resetCpuAffinity=True): Line 47: """ Line 48: Duplication of startCmd method without the use of deathSignal and sync Line 49: parameters. Using simple_exec_cmd will execute the command by popen Line 50: in sync to the call and return outputs. > start can't be done similar for both start and run - one uses popen without None should use deathSignal, but even if we keep deathSignal, we cannot duplicate the code like you did here. Line 51: Line 52: This is partial work to keep the usage of asyncProc in v2v and Line 53: imageSharing. Line 54: """ Line 114: p = AsyncProc(CPopen(command, close_fds=True, cwd=cwd, env=env, Line 115: deathSignal=deathSignal)) Line 116: if data is not None: Line 117: p.stdin.write(data) Line 118: p.stdin.flush() > we use it in some tests some tests can be deleted then. Line 119: Line 120: return p Line 121: Line 122: -- To view, visit https://gerrit.ovirt.org/60237 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id38507a04a124918f3865cf011bbf5adc7bc31d5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
