Yaniv Bronhaim has posted comments on this change. Change subject: stomp: simplified client ......................................................................
Patch Set 8: (2 comments) https://gerrit.ovirt.org/#/c/59151/8/lib/yajsonrpc/stompreactor.py File lib/yajsonrpc/stompreactor.py: Line 1 2014-2016 Line 575: ) Line 576: ) Line 577: Line 578: Line 579: def SimpleClient(host, port=54321, ssl=True): I'd default host to localhost Line 580: """ Line 581: Returns JsonRpcClient able to receive jsonrpc messages and notifications. Line 582: It is required to provide a host where we want to connect, port and whether Line 583: we want to use ssl (True by default). Other settings use defaults and if -- To view, visit https://gerrit.ovirt.org/59151 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b9b33474e60ab349885a7de18eeacc8f648011f Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
