Martin Polednik has posted comments on this change. Change subject: vm: split out SLA settings from domDependentInit ......................................................................
Patch Set 4: Code-Review-1 (1 comment) Almost insignificant comment on naming inside. https://gerrit.ovirt.org/#/c/59813/4/vdsm/virt/vm.py File vdsm/virt/vm.py: PS4, Line 1902: _dom_init_sla The name could be slightly improved - "SLA" is too specific to ovirt terminology. I'm not against keeping it in the method name, but it should also refer to what we're doing here (setting vcpu shares, tune, limits - probably _dom_vcpu_setup?). -- To view, visit https://gerrit.ovirt.org/59813 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9907a428b00d5851ece0037acfcc1ad72442ae46 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
