Dan Kenigsberg has posted comments on this change. Change subject: libvirtvm: Removing libvirt snapshot metadata. ......................................................................
Patch Set 1: I would prefer that you didn't submit this (2 inline comments) .................................................... File vdsm/libvirtvm.py Line 1912: self._updateDrive(drive) Line 1913: finally: Line 1914: self.startDisksStatsCollection() Line 1915: Line 1916: # Removing libvirt snapshot metadata I think it would be better to take this out of the while loop. Line 1917: curSnap = self._dom.snapshotCurrent(0) Line 1918: snapDelFlags = (libvirt.VIR_DOMAIN_SNAPSHOT_DELETE_METADATA_ONLY) Line 1919: curSnap.delete(snapDelFlags) Line 1920: Line 1914: self.startDisksStatsCollection() Line 1915: Line 1916: # Removing libvirt snapshot metadata Line 1917: curSnap = self._dom.snapshotCurrent(0) Line 1918: snapDelFlags = (libvirt.VIR_DOMAIN_SNAPSHOT_DELETE_METADATA_ONLY) why do we need this temp variable? Line 1919: curSnap.delete(snapDelFlags) Line 1920: Line 1921: # Successful Line 1922: break -- To view, visit http://gerrit.ovirt.org/9139 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I928983a404f822522a0a48218f9c58fa8d6296b1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
