Hello Roman Mohr, Dan Kenigsberg, Francesco Romani, Roy Golan, I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/60524 to review the following change. Change subject: Configure mom to ignore missing balloon device ...................................................................... Configure mom to ignore missing balloon device In the past MOM was only responsible for ballooning. But now it also manages some CPU and storage QoS settings. When there is no ballooning device on the VM, MOM completely ignores that VM and therefore does not set QoS attributes for CPU and storage. Change-Id: I855b62fcf835aa3520037a863c3dbc6681fee360 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1337882 Signed-off-by: Martin Sivak <msi...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/57796 Reviewed-by: Roman Mohr <rm...@redhat.com> Reviewed-by: Roy Golan <rgo...@redhat.com> Reviewed-by: Dan Kenigsberg <dan...@redhat.com> Continuous-Integration: Jenkins CI Reviewed-by: Francesco Romani <from...@redhat.com> (cherry picked from commit 77e45363ffbafe3e4edae313adb49b1dfc7a8bfe) Reviewed-on: https://gerrit.ovirt.org/59058 --- M vdsm.spec.in M vdsm/mom.conf.in 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/24/60524/1 diff --git a/vdsm.spec.in b/vdsm.spec.in index 58ad541..142e2e1 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -84,7 +84,7 @@ BuildRequires: libselinux-python BuildRequires: libvirt-python BuildRequires: m2crypto -BuildRequires: mom >= 0.5.3 +BuildRequires: mom >= 0.5.4 BuildRequires: openssl BuildRequires: policycoreutils-python BuildRequires: psmisc diff --git a/vdsm/mom.conf.in b/vdsm/mom.conf.in index fbcb56a..0388162 100644 --- a/vdsm/mom.conf.in +++ b/vdsm/mom.conf.in @@ -81,4 +81,4 @@ [guest] # A comma-separated list of Collector plugins to use for Guest data collection. -collectors: GuestQemuProc, GuestMemoryOptional, GuestBalloon, GuestCpuTune, GuestIoTune +collectors: GuestQemuProc, GuestMemoryOptional, GuestBalloonOptional, GuestCpuTune, GuestIoTune -- To view, visit https://gerrit.ovirt.org/60524 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I855b62fcf835aa3520037a863c3dbc6681fee360 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Roman Mohr <rm...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org