Shu Ming has posted comments on this change. Change subject: Integrate zombie reaper in test framework ......................................................................
Patch Set 3: No score Saggi, sorry about confusing. I suppose you mean the sleep child process in testProcessDiesAfterBeingTracked() is what you try to reap. I think if the zombieReaper.autoReapPID(p.pid) works, the child process should not have anything left in system including the pid, while the assert below throw exception when it doesn't get the child pid. Is it a wrong logic? Or is the comment below wrong? # Throws error because pid is not found or is not child self.assertRaises(OSError, os.waitpid, p.pid, .WNOHANG) self.assertRaises(OSError, os.waitpid, p.pid, os.WNOHANG) -- To view, visit http://gerrit.ovirt.org/8938 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74dec57129b65492d4bf41ce8fc2785d896f630e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
