Nir Soffer has posted comments on this change. Change subject: Modify reports to metrics ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/60450/2/lib/vdsm/config.py.in File lib/vdsm/config.py.in: Line 450: 'Metric collector type (supporting statsd or hawkular)'), Line 451: Line 452: ('queue_size', '100', Line 453: 'Number of metrics to queue if collector is not responsive.' Line 454: ' When the queue is full, oldest metrics are dropped. Used only' > that's where we were wrong. metrics == מדדים. we send the metrics - not sam We sample the system and report bunch of metrics on each sampling cycle. We queue groups of metrics, not single metrics. Make the comment clear about that. Line 455: ' by hawkular-client collector (default 100).'), Line 456: ]), Line 457: Line 458: # Section: [devel] -- To view, visit https://gerrit.ovirt.org/60450 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0aa10042b1c50fbdd94ae69053c74b57c3e6f40 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yaniv Kaul <yk...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
