Adam Litke has posted comments on this change. Change subject: sd: Move getVolumeLease to StorageDomainManifest ......................................................................
Patch Set 2: -Code-Review (1 comment) https://gerrit.ovirt.org/#/c/60282/2/vdsm/storage/sd.py File vdsm/storage/sd.py: Line 410: Line 411: def hasVolumeLeases(self): Line 412: return self._domainLock.supports_volume_leases Line 413: Line 414: def getVolumeLease(self, imgUUID, volUUID): Since this is already defined in both the file and block manifests, I don't think we need this implementation. Line 415: """ Line 416: Return the volume lease (leasePath, leaseOffset) Line 417: """ Line 418: return None, None -- To view, visit https://gerrit.ovirt.org/60282 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60b35e9a41d73ecba741d6fb9f90cdaeb35b3e3b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
