Nir Soffer has posted comments on this change. Change subject: Implement SDM.copy_data ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/60420/1/tests/storage_sdm_copy_data_test.py File tests/storage_sdm_copy_data_test.py: Line 50: Line 51: Line 52: def qemu_io_verify(path): Line 53: cmd = ['qemu-io', '-f', 'raw', Line 54: '-c', 'read -P %s -s 0 -l 1k 512 1k' % PATTERN, path] > Not sure this is necessary. The test does the following: OK, lets leave it as is. Line 55: out = subprocess.check_output(cmd, shell=False) Line 56: return "Pattern verification failed" not in out Line 57: Line 58: Line 52: def qemu_io_verify(path): Line 53: cmd = ['qemu-io', '-f', 'raw', Line 54: '-c', 'read -P %s -s 0 -l 1k 512 1k' % PATTERN, path] Line 55: out = subprocess.check_output(cmd, shell=False) Line 56: return "Pattern verification failed" not in out > I'll move this as you suggest. We want to test before and after copy so I OK. Is this the only way to detect verification - checking the text in the output? Line 57: Line 58: Line 59: @expandPermutations Line 60: class CopyDataTests(VdsmTestCase): -- To view, visit https://gerrit.ovirt.org/60420 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30ff635c0c73f67b296033b4a506fc3b9ededfbe Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
