Francesco Romani has posted comments on this change. Change subject: vm: always expect Vm devices to be sent ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/60322/3//COMMIT_MSG Commit Message: Line 17: Line 18: We can now drop this backward compatibility. Line 19: We start dropping the fallback code in the Vm device configuration. Line 20: Later patches will kill the Vm methods that rebuilt the device-specific Line 21: configuration data from the generic Vm.conf. > So we don't build the vm object now from the persisted conf? or these patch TL;DR: these patches do not affect recovering from pickled conf. Long version: In the creation path, if Vdsm hasn't receive device configuration in the "new" format (device list each element with its own conf), it rebuilds this configuration, and later saves it state; so the pickled conf is normalized and always in the "new" format. Vdsm 4.18.z (oVirt 4.0) already does that so (actually we do that also in 4.17.z), with this patch merged in 4.19.z (oVirt 4.1) we are safe to go for migrations or (de)hibernation. I can't think of one meaningful flow on which this could fail actually. Line 22: Line 23: Change-Id: I9d0b413d77bb908df218e3e009977f928a432b9d -- To view, visit https://gerrit.ovirt.org/60322 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d0b413d77bb908df218e3e009977f928a432b9d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
