Yaniv Bronhaim has submitted this change and it was merged. Change subject: sp: try lock when executing user initated pool upgrade ......................................................................
sp: try lock when executing user initated pool upgrade When attempting to execute upgradeStoragePool a concurrent update on one of the pool domains may be during execution and hold the pool upgrade lock. In that case, the request to acquire the lock will wait for the lock to be released which may cause the request to take longer then 3 minutes and cause to engine failover. When attempting to upgrade we should attempt to acquire the lock without wait (try to lock) and if we fail return error immediately, that scenario is rare and if it happens the user can simply try again. Change-Id: I93bfdcb19437fdc8901c08ea17dc80fe9c1e5510 Bug-Url: https://bugzilla.redhat.com/1260428 Signed-off-by: Liron Aravot <lara...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/59514 Reviewed-by: Nir Soffer <nsof...@redhat.com> Continuous-Integration: Jenkins CI Reviewed-on: https://gerrit.ovirt.org/60520 Reviewed-by: Yaniv Bronhaim <ybron...@redhat.com> Continuous-Integration: Yaniv Bronhaim <ybron...@redhat.com> --- M vdsm/storage/hsm.py M vdsm/storage/sp.py 2 files changed, 32 insertions(+), 25 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Yaniv Bronhaim: Looks good to me, approved; Passed CI tests Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/60520 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I93bfdcb19437fdc8901c08ea17dc80fe9c1e5510 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
