Dan Kenigsberg has posted comments on this change.
Change subject: Handle spaces in device names using lvm filter
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/lvm.py
Line 133: devs = []
Line 134: for dev in devList:
Line 135: if dev.strip():
Line 136: devs.append('\\\\\\\\x20'.join(dev.strip().
Line 137: encode("string_escape").split()))
I bet this breaks if you have trailing spaces, or consecutive spaces. To say
nothing about the pipe and percent chars.
Line 138: filt = '|'.join(devs)
Line 139: if len(filt) > 0:
Line 140: filt = "'a%" + filt + "%', "
Line 141:
--
To view, visit http://gerrit.ovirt.org/9191
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1efb6dfd30c0999f14c413fff778213b247a178f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
