Martin Polednik has uploaded a new change for review. Change subject: network/sr-iov: use setup in hotplug routine ......................................................................
network/sr-iov: use setup in hotplug routine Setup is new preferred way of setting up a device. Network used code in hotplugNic method to handle detaching of the device, it's more future proof to use the setup method. Change-Id: I88517f61d286a313e496fd02cb949d38c9b683b3 Signed-off-by: Martin Polednik <[email protected]> --- M vdsm/virt/vm.py 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/04/60904/1 diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py index 4dd7596..491edc0 100644 --- a/vdsm/virt/vm.py +++ b/vdsm/virt/vm.py @@ -2141,8 +2141,7 @@ self.log.info("Hotplug NIC xml: %s", nicXml) try: - if nic.is_hostdevice: - hostdev.detach_detachable(nicParams[hwclass.HOSTDEV]) + nic.setup() self._dom.attachDevice(nicXml) except libvirt.libvirtError as e: self.log.exception("Hotplug failed") -- To view, visit https://gerrit.ovirt.org/60904 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I88517f61d286a313e496fd02cb949d38c9b683b3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
