Shu Ming has posted comments on this change.
Change subject: remoteFileHandler: improve PYTHONPATH definition
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/remoteFileHandler.py
Line 220: try:
Line 221: # Some imports in vdsm assume /usr/share/vdsm is in your
PYTHONPATH
Line 222: env = os.environ.copy()
Line 223: env['PYTHONPATH'] = "%s:%s" % (
Line 224: constants.P_VDSM, env.get("PYTHONPATH", ""))
Can you make sure that if we still need constants.P_VDSM if "../" is added into
the sys path in misc.py? I think they are redundant efforts to locate the
files in the upper level directory.
Line 225: self.process = BetterPopen([constants.EXT_PYTHON,
__file__,
Line 226: str(hisRead), str(hisWrite)], close_fds=False,
env=env)
Line 227:
Line 228: self.proxy = CrabRPCProxy(myRead, myWrite)
--
To view, visit http://gerrit.ovirt.org/9193
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I29dd748bcc9658a98ad86313921bfd94c96b83a6
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
