Zhou Zheng Sheng has posted comments on this change. Change subject: Sending sigkill to verify svdsm suicide ......................................................................
Patch Set 1: I would prefer that you didn't submit this (2 inline comments) .................................................... Commit Message Line 7: Sending sigkill to verify svdsm suicide Line 8: Line 9: Svdsm was alive after restart of vdsm. svdsm should use pokeParent Line 10: thread to distinguish vdsm pid status, when it recognizes that vdsm pid Line 11: is not exist, svdsm kills itself by sending SIGKILL. SIGKILL <--> SIGTERM ? Line 12: Line 13: The patch changes the signal to SIGKILL and verifies that in the except Line 14: scope we won't get exception before calling to os.kill. Line 15: .................................................... File vdsm/supervdsmServer.py Line 292: while True: Line 293: os.kill(parentPid, 0) Line 294: sleep(2) Line 295: except Exception: Line 296: if os.path.exists(ADDRESS): Looks utils.rmFile() is what you need. Line 297: os.unlink(ADDRESS) Line 298: os.kill(os.getpid(), signal.SIGKILL) Line 299: Line 300: -- To view, visit http://gerrit.ovirt.org/9196 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2eb8f1a74f818cd10a08572c9adb5de1c0e21f5a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
