Gal Hammer has posted comments on this change.
Change subject: Add qemu's memory usage to VM statistics.
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File vdsm/libvirtvm.py
Line 173:
Line 174: def _sampleMem(self):
Line 175: memUsage = {}
Line 176: if self.conf['pid'] != '0':
Line 177: for line in open('/proc/%d/status' % (self.conf['pid'])):
I'm sure not about the fd leak, but I don't mind changing the code.
Done.
Line 178: var, value = line.strip().split()[0:2]
Line 179: if var in ('VmSize:', 'VmRSS:', 'VmData:'):
Line 180: memUsage[var[:-1]] = long(value)
Line 181: return memUsage
--
To view, visit http://gerrit.ovirt.org/9006
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibeb35759454c4a9b41e1303956267e93ca3545a0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer <[email protected]>
Gerrit-Reviewer: Gal Hammer <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
