Francesco Romani has posted comments on this change. Change subject: virt: Switch to etree in vmxml.py ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/58196/5/tests/deviceTests.py File tests/deviceTests.py: PS5, Line 252: (etree.tostring I'd like to have a xml helper for this, and not use etree explicitely *in this series*. Once we settle for the open questions you (justly) raised in the patch starting the series, we could change this. -- To view, visit https://gerrit.ovirt.org/58196 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7c6d3d6e6bf5ae012f2e0ee4363f742a8cfcdcce Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org