Dan Kenigsberg has submitted this change and it was merged. Change subject: migration: wait properly for migration to begin ......................................................................
migration: wait properly for migration to begin If the time it takes the migration to begin is longer than the MIGRATION_MONITOR_INTERVAL (may happen due to networking issues), the first call to Progress.from_job_stats(self._vm._dom.jobStats()) leads to an exception because the stats don't contain the statistics yet. This situation causes the monitor thread to die (even though the migration will continue and eventually pass). Fixed by: - making sure the from_job_stats() will be called only if the migration is ongoing - adding a check which makes sure that the monitor thread will be executing its logic only if the migration is ongoing Change-Id: If1ba369a0992c2473acf1395fad0b0c260c250ba Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1354344 Backport-To: 4.0 Signed-off-by: Tomas Jelinek <[email protected]> Reviewed-on: https://gerrit.ovirt.org/60073 Continuous-Integration: Jenkins CI Reviewed-by: Francesco Romani <[email protected]> --- M tests/vmMigrationTests.py M vdsm/virt/migration.py 2 files changed, 20 insertions(+), 10 deletions(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60073 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1ba369a0992c2473acf1395fad0b0c260c250ba Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
