Dan Kenigsberg has submitted this change and it was merged. Change subject: tox: fail make process if required tox version isn't installed. ......................................................................
tox: fail make process if required tox version isn't installed. Over RHEL 7.2 yum contains only tox-1.4.2 which doesn't fit to vdsm requirements. We require to install tox with pip currently. This patch validates tox and its version and fails the make process if tox is older than 2.1.1 tox check was removed from configure.ac and now it's existence will be checked only during the build process. Change-Id: I665025dacdd5346a5e021ac98e864f7b6461917c Signed-off-by: Irit Goihman <igoih...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/59306 Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer <nsof...@redhat.com> Reviewed-by: Yaniv Bronhaim <ybron...@redhat.com> Reviewed-by: Dan Kenigsberg <dan...@redhat.com> --- M Makefile.am A build-aux/vercmp M configure.ac M tox.sh 4 files changed, 92 insertions(+), 18 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Yaniv Bronhaim: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Irit Goihman: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/59306 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I665025dacdd5346a5e021ac98e864f7b6461917c Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
