Dan Kenigsberg has posted comments on this change.

Change subject: contrib: jsonrpc: add example script to run a VM
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/61047/2/contrib/runvm
File contrib/runvm:

PS2, Line 107:  conf['vmId']
let's be python3-ready


https://gerrit.ovirt.org/#/c/61047/2/contrib/vmconfig.json
File contrib/vmconfig.json:

Line 4:     "cpuType": "Haswell-noTSX", 
Line 5:     "custom": {}, 
Line 6:     "devices": [
Line 7:       {
Line 8:         "device": "qxl", 
could you provide the simplest-possible json, to start a VM with VNC (which is 
easier to consume than spice) and no networking?

it would better have the simplest most common cpuType as well, to be runnable 
everywhere.
Line 9:         "deviceId": "742fb294-abad-4fb5-ba38-4c99a748093d", 
Line 10:         "specParams": {
Line 11:           "heads": "1", 
Line 12:           "ram": "65536", 


-- 
To view, visit https://gerrit.ovirt.org/61047
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idc8ec3a6ea795659834392f94e7649218ac3fda8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Reply via email to