Milan Zamazal has posted comments on this change. Change subject: virt: Use DOM helpers in Vm._findGraphicsDeviceXMLByType etc. ......................................................................
Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/56107/6/vdsm/virt/vm.py File vdsm/virt/vm.py: PS6, Line 4016: """ > (not sure this is actually the case but) let's pay attention to name clashe It can't cause any problem unless we want to use a fully qualified imported name here, but a different name can be used anyway. Done. -- To view, visit https://gerrit.ovirt.org/56107 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15b041ab89caa7b967d2a7e0a9d262274a5a3f90 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org