Francesco Romani has submitted this change and it was merged. Change subject: oop: Explicitly close running ioprocesses ......................................................................
oop: Explicitly close running ioprocesses IOProcess client is using __del__ for automatic closing when the last reference to the client disappears. This attempt fail consistency when __del__ is called during shutdown, since Python is partly tore down. In the worst cases, the entire application will get stuck during shutdown. We see this randomly when running the tests in the CI. Looking in backtraces, all the threads are blocked trying to acquire a lock that may have been already destroyed. This patch avoid this issue by explicitly closing all running ioprocesses during application shutdown and when cleaning up after storage tests. This ensure that IOProcess's close() and __del__() are running in a well defined environment. Change-Id: Id9fce2bcc8a7916dd9e31a8b23a4199611c7938f Bug-Url: https://bugzilla.redhat.com/1334274 Signed-off-by: Nir Soffer <nsof...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/60830 Continuous-Integration: Jenkins CI Reviewed-by: Francesco Romani <from...@redhat.com> Reviewed-by: Adam Litke <ali...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/61050 --- M tests/storagetestlib.py M vdsm/storage/hsm.py M vdsm/storage/outOfProcess.py 3 files changed, 28 insertions(+), 2 deletions(-) Approvals: Nir Soffer: Verified Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61050 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id9fce2bcc8a7916dd9e31a8b23a4199611c7938f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
