Francesco Romani has posted comments on this change. Change subject: virt: Make DomainDescriptor use XML helpers ......................................................................
Patch Set 7: (2 comments) https://gerrit.ovirt.org/#/c/55769/7/tests/vmXmlTests.py File tests/vmXmlTests.py: Line 118: element = None Line 119: text = vmxml.dom_text(element) Line 120: self.assertIsInstance(text, result.__class__) Line 121: self.assertEqual(text, result) Line 122: > I'm definitely going to check test coverage of all the new and modified cod Fine for me. Line 123: Line 124: @expandPermutations Line 125: class TestDomainDescriptor(VmXmlTestCase): Line 126: https://gerrit.ovirt.org/#/c/55769/7/vdsm/virt/vmxml.py File vdsm/virt/vmxml.py: PS7, Line 37: xml_to_dom > It would be nice but it would require using wrapped elements and using the Agreed: let's start with the functions, and let's do the switch to etree. This is the big goal after all :) Once this is done, we could discuss if we need wrapper object or not. -- To view, visit https://gerrit.ovirt.org/55769 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib169735936d19171ff8b8d127666d7258c308f34 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
