Francesco Romani has posted comments on this change. Change subject: vdsm: virt: add optional container support ......................................................................
Patch Set 39: (1 comment) https://gerrit.ovirt.org/#/c/53820/39/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1830: self.log.error("Failed to make a agent channel symlink " Line 1831: "from %s -> %s for channel %s", path, Line 1832: uuidPath, name) Line 1833: Line 1834: def _domDependentInit(self): alternative approach: dup this method, like I did in https://gerrit.ovirt.org/#/c/54179/24/vdsm/virt/vm.py Line 1835: if self._destroy_requested.is_set(): Line 1836: # reaching here means that Vm.destroy() was called before we could Line 1837: # handle it. We must handle it now Line 1838: try: -- To view, visit https://gerrit.ovirt.org/53820 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id236a30a5c875994c037b8d00c7463bceaab143f Gerrit-PatchSet: 39 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
