Dan Kenigsberg has posted comments on this change. Change subject: network/sr-iov: use device teardown to reattach device ......................................................................
Patch Set 6: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/60667/6/vdsm/virt/vmdevices/network.py File vdsm/virt/vmdevices/network.py: Line 198: detach_detachable(self.hostdev) Line 199: Line 200: def teardown(self): Line 201: if self.is_hostdevice: Line 202: self.log.debug('Reattaching device %s to host.' % self.hostdev) > Will add at the end of branch (to avoid rebasing everything). ... and to avoid making patch more than just code moving. Line 203: try: Line 204: # TODO: avoid reattach when Engine can tell free VFs otherwise Line 205: reattach_detachable(self.hostdev) Line 206: except NoIOMMUSupportException: -- To view, visit https://gerrit.ovirt.org/60667 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ff3299e4a9baaf02a3b96cd94cdf9871d190b17 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
