Francesco Romani has posted comments on this change. Change subject: utils: add utlity to generate positive cpuset notation ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/60639/4/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 932: return dict Line 933: return rget(dict.get(keys[0]), keys[1:], default) Line 934: Line 935: Line 936: def cpuset(included_cpus): > cpuinfo.py Not terribly against this, but still suboptimal; isn't cpuinfo about parsing /proc/cpuinfo and present the content in a convenient way? adding those two functions feels like a stretch. Line 937: """ Line 938: Create a "positive" cpuset notation. The cpuset notation is a string Line 939: containing groups of ranges of numbers or numbers itself, describing Line 940: which CPUs are included. The groups are separated by comma, ranges by dash. -- To view, visit https://gerrit.ovirt.org/60639 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba61cf59d17fed6b0d7a035f948885ce73c92bf1 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
