Federico Simoncelli has posted comments on this change. Change subject: vm: increase the volume extension on storage migration ......................................................................
Patch Set 1: (1 inline comment) .................................................... File vdsm/vm.py Line 799: return Line 800: Line 801: if newSize is None: Line 802: # newSize is always in megabytes Line 803: newSize = (vmDrive.volExtensionChunk + Wouldn't this duplicate this code to at least three different places (diskReplicateStart, abnormalVmStop, highWrite)? With the current code we have a doubled extension if diskReplicate is present (regardless where the call comes from). Why wouldn't you want a double extension in highWrite? (BTW I think that the call in abnormalVmStop is useless, it has also been proven by the fact that now sometimes we receive EOTHER and the extension works fine since it's handled by highWrite). Actually my initial idea was to move this computation in the vmDrive object (eg: vmDrive.nextVolumeSize) to keep all the logic there (skipped because I didn't want to change too many things). Line 804: ((vmDrive.apparentsize + constants.MEGAB - 1) / Line 805: constants.MEGAB)) Line 806: Line 807: if getattr(vmDrive, 'diskReplicate', None): -- To view, visit http://gerrit.ovirt.org/9200 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib61375613712feb7118a80c50b73e678d257f251 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
