Edward Haas has posted comments on this change. Change subject: ovs: acquire external ifaces ......................................................................
Patch Set 25: Code-Review-1 (3 comments) https://gerrit.ovirt.org/#/c/60404/25/tests/network/ovs_switch_test.py File tests/network/ovs_switch_test.py: Line 28: @attr(type='unit') Line 29: class ListAcquiredIfacesTests(VdsmTestCase): Line 30: Line 31: @mock.patch('vdsm.network.ovs.info.OvsInfo') Line 32: def test_add_network_with_nic(self, mock_ovs_info): Q: What happens when a network is removed and then added again? Are we acquire it twice? There is a remove-add in the same transaction, and the same in different setup commands. Line 33: mock_ovs_info.bridges = {} Line 34: mock_ovs_info.bridges_by_sb = {} Line 35: mock_ovs_info.northbounds_by_sb = {} Line 36: PS25, Line 53: set() Seems like a problem, don't you think? When we acquire a bond, we implicitly acquire its slaves. PS25, Line 82: expected_ifaces move last -- To view, visit https://gerrit.ovirt.org/60404 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a08095e03a3167d0be4f7261b9a43c9cf92c67b Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
