Nir Soffer has posted comments on this change. Change subject: docs: add README about logging configuration ......................................................................
Patch Set 4: (3 comments) https://gerrit.ovirt.org/#/c/60533/4/README.logging File README.logging: Line 25: The basic syntax is: Line 26: Line 27: # vdsClient [options] setLogLevel LEVEL [logger] Line 28: Line 29: `LEVEL` is one of DEBUG, INFO, WARNING, ERROR, CRITICAL Please do not document ERROR and CRITICAL, we don't want people to use these log levels, we cannot support system running with CRITICAL (there will be no logs) and seeing only errors is also quite unsupportable. Or add a warning about using these levels. Line 30: `logger` is any logger Vdsm uses. Please check the configuration file Line 31: to learn about some predefined loggers. Line 32: Line 33: If no logger is given, the root logger is used implicitely. Line 46: vdsClient -s 0 setLogLevel WARNING virt Line 47: Line 48: 3. same as #2, for storage (case is significant here) Line 49: vdsClient -s 0 setLogLevel WARNING Storage Line 50: vdsClient -s 0 setLogLevel WARNING storage Unified in https://gerrit.ovirt.org/61261, please update when that patch is merged. Line 51: Line 52: 4. silence JSONRPC logs: Line 53: vdsClient -s 0 setLogLevel ERROR jsonrpc Line 54: Line 49: vdsClient -s 0 setLogLevel WARNING Storage Line 50: vdsClient -s 0 setLogLevel WARNING storage Line 51: Line 52: 4. silence JSONRPC logs: Line 53: vdsClient -s 0 setLogLevel ERROR jsonrpc This is bad idea, please use WARNING. Line 54: Line 55: Line 56: Notes Line 57: ----- -- To view, visit https://gerrit.ovirt.org/60533 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2653c2a68fcf42b1e085ae1ee703fb119a0cf1fc Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
