Eduardo has uploaded a new change for review.

Change subject: Not remove volumeless or inexistent images.
......................................................................

Not remove volumeless or inexistent images.

Change-Id: I04af8d9ece52a1973180dc77991364785516a02a
Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=876115
Signed-off-by: Eduardo <[email protected]>
---
M vdsm/storage/image.py
1 file changed, 6 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/44/9244/1

diff --git a/vdsm/storage/image.py b/vdsm/storage/image.py
index 73274fe..0265dcc 100644
--- a/vdsm/storage/image.py
+++ b/vdsm/storage/image.py
@@ -36,6 +36,8 @@
 import resourceFactories
 import resourceManager as rm
 import outOfProcess as oop
+
+log = logging.getLogger('Storage.Image')
 rmanager = rm.ResourceManager.getInstance()
 
 # Disk type
@@ -74,7 +76,10 @@
     """
     allVols = dom.getAllVolumes()
     imgVols = sd.getVolsOfImage(allVols, imgUUID)
-    if postZero:
+    if not imgVols:
+        log.warning("No volumes found for image %s. %s", imgUUID, allVols)
+        return
+    elif postZero:
         dom.zeroImage(dom.sdUUID, imgUUID, imgVols)
     else:
         dom.deleteImage(dom.sdUUID, imgUUID, imgVols)


--
To view, visit http://gerrit.ovirt.org/9244
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I04af8d9ece52a1973180dc77991364785516a02a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to