Martin Polednik has posted comments on this change. Change subject: virt: utils: add is_kvm helper ......................................................................
Patch Set 28: (1 comment) https://gerrit.ovirt.org/#/c/55647/28/tests/vmUtilsTests.py File tests/vmUtilsTests.py: PS28, Line 224: def test_container_type(self): : self.assertFalse(utils.is_kvm({ : 'vmType': 'kvm', : 'custom': { : 'containerType': 'rkt', : }, : })) > Sorry, I don't follow. What would you like me to do here? What is the point of vmType then? We could drop (deprecate it) and rely on custom property. If the code is supposed to be in VDSM (and that it is), it should act as a first class citizen of "application isolation" (= set(virtualization, containerization, ...). -- To view, visit https://gerrit.ovirt.org/55647 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f9e1b8f9326e565ee7324d0b328100ca86c6967 Gerrit-PatchSet: 28 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
