Ramesh N has posted comments on this change. Change subject: gluster:enforce gluster fencing policies ......................................................................
Patch Set 9: (4 comments) https://gerrit.ovirt.org/#/c/59600/9/lib/vdsm/gluster/fence.py File lib/vdsm/gluster/fence.py: Line 19: # Line 20: from __future__ import absolute_import Line 21: Line 22: import math Line 23: import logging > newline between different type of imports Done Line 24: from vdsm.gluster import exception as ge Line 25: Line 26: Line 27: log = logging.getLogger("Gluster") Line 26: Line 27: log = logging.getLogger("Gluster") Line 28: Line 29: Line 30: def canFenceHost(vdsmProxy, hostUuid, skipFecingIfGlusterBricksUp, > camelCase or under_line_case? choose one and be consistence. it should be c Done Line 31: skipFencingIfGlusterQuorumNotMet): Line 32: volumesList = _getVolumeInfo(vdsmProxy) Line 33: for volumeName in volumesList: Line 34: if 'REPLICATE' in volumesList.get(volumeName).get('volumeType'): https://gerrit.ovirt.org/#/c/59600/9/vdsm.spec.in File vdsm.spec.in: Line 1648: %license COPYING Line 1649: %{_datadir}/%{vdsm_name}/gluster/api.py* Line 1650: %{_datadir}/%{vdsm_name}/gluster/apiwrapper.py* Line 1651: %{_datadir}/%{vdsm_name}/gluster/fstab.py* Line 1652: %{python_sitelib}/%{vdsm_name}/gluster/fence.py* > got confused about what should be under vdsm-gluster and what comes with vd Basically all gluster related things which are not required incase of regular virt cases will be added to vdsm-gluster. I will add a comment about it in the spec file. Line 1653: %{python_sitelib}/%{vdsm_name}/rpc/vdsm-api-gluster.yml Line 1654: %{_datadir}/%{vdsm_name}/gluster/gfapi.py* Line 1655: %{_datadir}/%{vdsm_name}/gluster/hooks.py* Line 1656: %{_datadir}/%{vdsm_name}/gluster/services.py* https://gerrit.ovirt.org/#/c/59600/9/vdsm/API.py File vdsm/API.py: PS9, Line 1296: will not " : "enforced > will not be enforced Done -- To view, visit https://gerrit.ovirt.org/59600 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c18571209a3a7682a43bd2814b9ee3f0a69c55f Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Darshan N <dnara...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
