Martin Polednik has posted comments on this change. Change subject: modprobe: set bonding max_bonds to 0 ......................................................................
Patch Set 1: Code-Review-1 Two concerns: First, the name "modprobe.conf" later renamed to "vdsm.conf" is bad. It is nicer to pick name that doesn't have to be changed in the process even when there is some context duplication - please consider vdsm-modprobe.conf. Second, not directly related to the patch, is that we currently store system configuration "assets" under vdsm directory. That is mixing static files with source code. We should think of creating a new directory or finding standardized way of shipping such files. This is beyond the scope of the patch though (due to needed backport afaik). -- To view, visit https://gerrit.ovirt.org/61396 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic264e8a89eb07b8da42494a9b12ac9c871f78c51 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
