Edward Haas has posted comments on this change. Change subject: ifcfg: write current DNS information to a management network's ifcfg file ......................................................................
Patch Set 4: (4 comments) https://gerrit.ovirt.org/#/c/61184/4/lib/vdsm/network/configurators/ifcfg.py File lib/vdsm/network/configurators/ifcfg.py: PS4, Line 575: PEERDNS=yes, to be on the safe side in the future? > I'll move this comment to a later patch, OK. Yes under the 'if ipv4.defaultRoute is not None' condition. PS4, Line 579: DOMAIN= > For the same reason this patch exists: to preserve (full) DNS configuration I do not understand... we just need to keep the existing functionality of the ifcfg scripts. If we are not preserving the original DNS settings from the ifcfg config (before we acquired it), then this patch does not comply with the need. is this the case? https://gerrit.ovirt.org/#/c/61184/4/lib/vdsm/network/legacy_switch.py File lib/vdsm/network/legacy_switch.py: Line 160: top_net_dev.ipv6 = IPv6( Line 161: ipv6addr, ipv6gateway, defaultRoute, ipv6autoconf, dhcpv6) Line 162: top_net_dev.blockingdhcp = (configurator._inRollback or Line 163: utils.tobool(blockingdhcp)) Line 164: if defaultRoute: > I wanted to add DNS information specifically (only) to the management netwo I understand the heuristic, but it does not need to appear here. It's enough to have it in the ifcfg module. Line 165: top_net_dev.nameservers = _netinfo.nameservers Line 166: return top_net_dev Line 167: Line 168: https://gerrit.ovirt.org/#/c/61184/4/tests/network/models_test.py File tests/network/models_test.py: PS4, Line 142: 'dnss' > Really, if I was new to the project, I would wonder -- this means DNS, righ Unfortunately, this may break comparability as it is reported back to Engine. You can raise it with the Engine guys and check if it is. -- To view, visit https://gerrit.ovirt.org/61184 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie10ee7938b26a7f3b2b7be80bc1a2a83cd1c376c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabi...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
