Mark Wu has posted comments on this change.
Change subject: add emulator pin support to create vm
......................................................................
Patch Set 6: I would prefer that you didn't submit this
(1 inline comment)
Since you move cputune xml generation code out of appendCpu, it breaks the test
case testCpuXML in libvirtvmTests.py. So you need update the test case too. It
looks that you also need an update on vdsm api schema.
....................................................
Commit Message
Line 7: add emulator pin support to create vm
Line 8:
Line 9: move cpupin to a seperate function 'appendTunable'
Line 10: to add cputune(e.g.cpu_share),memtune limit def when create vm.
Line 11: add emulator pin support to create vm,
it looks the commit message doesn't match with the code.
Line 12: then the cpuPinning dict changs to be:
Line 13: {0:'1-4','emulator':'2'}
Line 14:
Line 15: Change-Id: Ic616b825eca94682e1563ab51773d8a23351998d
--
To view, visit http://gerrit.ovirt.org/8411
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic616b825eca94682e1563ab51773d8a23351998d
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
