Adam Litke has posted comments on this change. Change subject: storage: Introduce guarded utilities ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/61435/1/lib/vdsm/storage/guarded.py File lib/vdsm/storage/guarded.py: Line 49: locks = [] Line 50: for entity in entities: Line 51: locks.extend(entity.get_rm_locks()) Line 52: Line 53: # Exclusive locks always take precedence over shared > Exactly. I'll reword it. I think there are valid scenarios when you'd hav We decided to remove this handling and let locking errors happen naturally in this situation since we can't think of a valid use case now. Line 54: lock_set = set([l for l in locks if l.mode == rm.LockType.exclusive]) Line 55: shared_locks = set([l for l in locks if l.mode == rm.LockType.shared]) Line 56: lock_set.update(shared_locks) Line 57: return sorted(lock_set) -- To view, visit https://gerrit.ovirt.org/61435 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b0a204818d44b6205515277f4c2834cb2b7a057 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
