Milan Zamazal has posted comments on this change. Change subject: configs: move logger to static ......................................................................
Patch Set 1: Code-Review-1 (3 comments) https://gerrit.ovirt.org/#/c/61601/1/static/Makefile.am File static/Makefile.am: Line 22: Line 23: vdsmconf_DATA = \ Line 24: logger.conf \ Line 25: svdsm.logger.conf \ Line 26: $(NULL) Why the NULL thing in all the rules? Line 27: Line 28: CLEANFILES = \ Line 29: $(NULL) Line 30: Line 28: CLEANFILES = \ Line 29: $(NULL) Line 30: Line 31: EXTRA_DIST = \ Line 32: logger.conf \ If we can't use a single rule for vdsmconf_DATA and EXTRA_DIST, let's use $(vdsmconf_DATA) here instead of copy&paste. Line 33: svdsm.logger.conf Line 29: $(NULL) Line 30: Line 31: EXTRA_DIST = \ Line 32: logger.conf \ Line 33: svdsm.logger.conf Backslash missing. -- To view, visit https://gerrit.ovirt.org/61601 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7894e7d48047a6cb8b1f2482fd44c89b9260797e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
