Shu Ming has posted comments on this change. Change subject: Adding support for force extend block domains ......................................................................
Patch Set 7: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/BindingXMLRPC.py Line 408: def domainDetachForced(self, sdUUID, spUUID, options=None): Line 409: domain = API.StorageDomain(sdUUID, spUUID) Line 410: return domain.detach(None, None, force=True) Line 411: Line 412: def domainExtend(self, sdUUID, spUUID, devlist, force=False, options=None): If an older version of Engine to call domainExtend() without 'force' parameter, the newer versiondomainExtend() may mis-understand the 'options' parameter. So it is reasonable to move 'force' to the last one just after 'options' for backward compatibility. Line 413: domain = API.StorageDomain(sdUUID, spUUID) Line 414: return domain.extend(devlist, force) Line 415: Line 416: def domainFormat(self, sdUUID, -- To view, visit http://gerrit.ovirt.org/9192 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33ad4ee65d7303705d2cc8370502553125000ca0 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
