Petr Horáček has posted comments on this change. Change subject: ovs: copy NIC hwaddr to NB ......................................................................
Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/61049/9/lib/vdsm/network/ovs/switch.py File lib/vdsm/network/ovs/switch.py: Line 267: def _random_unicast_local_mac(): Line 268: # TODO: use prefix specified for OVS internal ifaces Line 269: mac = [ Line 270: 0b00000010, Line 271: random.randint(0x00, 0xff), > It's just shorter. The mask is not enough, we must set 7. bit to 1 and 8. to 0. Done. Line 272: random.randint(0x00, 0xff), Line 273: random.randint(0x00, 0xff), Line 274: random.randint(0x00, 0xff), Line 275: random.randint(0x00, 0xff)] -- To view, visit https://gerrit.ovirt.org/61049 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibfd22d101868b56c6f0a7ba9b41d43dc5784bdb8 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
