Edward Haas has posted comments on this change. Change subject: net: introduce acquire module ......................................................................
Patch Set 21: Code-Review+1 (1 comment) Very nice. Only one recommendation for comment. https://gerrit.ovirt.org/#/c/60974/21/tests/network/ifacquire_test.py File tests/network/ifacquire_test.py: PS21, Line 106: 'atomic_file_write', : new_callable=mock.mock_open Ha... this works just because these atomic_file_write has an api similar to open. Seems like a unique thing to do... better comment it here. -- To view, visit https://gerrit.ovirt.org/60974 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I180cfd7d69c0ae0a24188bc3d909b9d3d7c12145 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
