Edward Haas has posted comments on this change. Change subject: ovs: acquire ifaces ......................................................................
Patch Set 34: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/60404/34/lib/vdsm/network/ovs/switch.py File lib/vdsm/network/ovs/switch.py: Line 69: self._acquired_ifaces = set() Line 70: Line 71: @property Line 72: def acquired_ifaces(self): Line 73: """Interfaces used by networks and bonds in this setup.""" I prefer a more descriptive and detailed explanation. Something like: Report the ifaces that have been added to networks, either by add or edit actions, including ifaces that have been removed and re-added to a different network. Line 74: return self._acquired_ifaces Line 75: Line 76: def __enter__(self): Line 77: return self https://gerrit.ovirt.org/#/c/60404/34/tests/network/ovs_switch_test.py File tests/network/ovs_switch_test.py: PS34, Line 86: _empty_mock_ovs_info(mock_ovs_info) _init_ovs_info(info) -- To view, visit https://gerrit.ovirt.org/60404 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a08095e03a3167d0be4f7261b9a43c9cf92c67b Gerrit-PatchSet: 34 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/admin/lists/[email protected]
